- Make every statically-poked method public and call it directly,
keeping `public_send` only for dynamically-named public methods.
- Read and write state through public `attr_*` accessors instead of
instance variable reflection.
- Enable `Homebrew/NoSendInTests` and
`Homebrew/NoInstanceVariableAccessInTests` now the test suite is
clean, so neither pattern creeps back in.
- Keep rare justified disables, e.g. `Module#remove_const` is
private core Ruby and raw memoisation state has no accessor.
- Enable `HOMEBREW_SANDBOX_LINUX` in developer mode so maintainers
exercise the staged Linux sandbox default early.
- Materialise developer-mode defaults in `brew.sh` so `EnvConfig`
reads explicit environment state instead of inferring it.
- Let `HOMEBREW_UPGRADE_AUTO_UPDATES_CASKS` use the generated
`EnvConfig` reader because the developer default is set in `brew.sh`.
- Keep explicit opt-in and opt-out conflicts as usage errors so
users get a clear failure instead of silent precedence.
- Add `bubblewrap` as a Linux implicit dependency when no usable
`bwrap` exists, so it is fetched early and installed before other
formulae that need sandboxed install steps.
- Limit versioned sibling lookup to gcc and glibc global deps so API
sourced formulae can still load without tap or path metadata.
- Suppress recursive sandbox bootstrapping while installing Bubblewrap
and its own dependency chain.
- Skip the Linux sandbox doctor warning in containers where host
namespace policy controls Bubblewrap viability.
- Keep `HOMEBREW_NO_SANDBOX_LINUX` as the explicit opt-out for
systems where Bubblewrap is not yet usable.
- Add the `# odeprecated` note and regenerated manpage text for the
next release default.
- Previously I thought that comments were fine to discourage people from
wasting their time trying to bump things that used `undef` that Sorbet
didn't support. But RuboCop is better at this since it'll complain if
the comments are unnecessary.
- Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501.
- I've gone for a mixture of `rubocop:disable` for the files that can't
be `typed: strict` (use of undef, required before everything else, etc)
and `rubocop:todo` for everything else that should be tried to make
strictly typed. There's no functional difference between the two as
`rubocop:todo` is `rubocop:disable` with a different name.
- And I entirely disabled the cop for the docs/ directory since
`typed: strict` isn't going to gain us anything for some Markdown
linting config files.
- This means that now it's easier to track what needs to be done rather
than relying on checklists of files in our big Sorbet issue:
```shell
$ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l
268
```
- And this is confirmed working for new files:
```shell
$ git status
On branch use-rubocop-for-sorbet-strict-sigils
Untracked files:
(use "git add <file>..." to include in what will be committed)
Library/Homebrew/bad.rb
Library/Homebrew/good.rb
nothing added to commit but untracked files present (use "git add" to track)
$ brew style
Offenses:
bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true.
^^^^^^^^^^^^^
1340 files inspected, 1 offense detected
```
- Found with
`grep -rL "# typed: strict" Library/Homebrew | xargs grep -l "undef "`.
- This stops people from trying to bump them and
getting an error that they can't fix because
[it's a Sorbet limitation](https://sorbet.org/docs/error-reference#3008),
wasting contributor time.
- Add more early return checks
- Move to a recursive approach for more readability and avoiding a
counter that we need to bump
- Perform more caching
- Keep class variable usage isolated into specific methods
Mike McQuaid