mirror of
https://github.com/Homebrew/brew.git
synced 2026-08-12 22:29:27 +04:00
- Make every statically-poked method public and call it directly, keeping `public_send` only for dynamically-named public methods. - Read and write state through public `attr_*` accessors instead of instance variable reflection. - Enable `Homebrew/NoSendInTests` and `Homebrew/NoInstanceVariableAccessInTests` now the test suite is clean, so neither pattern creeps back in. - Keep rare justified disables, e.g. `Module#remove_const` is private core Ruby and raw memoisation state has no accessor.
180 lines
6.0 KiB
Ruby
180 lines
6.0 KiB
Ruby
# typed: true
|
|
# frozen_string_literal: true
|
|
|
|
require "dependency"
|
|
|
|
RSpec.describe Dependency do
|
|
let(:foo) { build_dep(:foo) }
|
|
let(:bar) { build_dep(:bar) }
|
|
let(:baz) { build_dep(:baz) }
|
|
let(:qux) { build_dep(:qux) }
|
|
let(:deps) { [foo, bar, baz, qux] }
|
|
let(:formula) { instance_double(Formula, deps:, name: "f") }
|
|
|
|
def build_dep(name, tags = [], deps = [])
|
|
dep = Dependency.new(name.to_s, tags)
|
|
allow(dep).to receive(:to_formula).and_return \
|
|
instance_double(Formula, deps:, name:, full_name: name)
|
|
dep
|
|
end
|
|
|
|
describe "::expand" do
|
|
it "yields dependent and dependency pairs" do
|
|
i = 0
|
|
described_class.expand(formula) do |dependent, dep|
|
|
expect(dependent).to eq(formula)
|
|
expect(deps[i]).to eq(dep)
|
|
i += 1
|
|
nil
|
|
end
|
|
end
|
|
|
|
it "returns the dependencies" do
|
|
expect(described_class.expand(formula)).to eq(deps)
|
|
end
|
|
|
|
it "prunes all when given a block with PRUNE" do
|
|
expect(described_class.expand(formula) { next Dependable::PRUNE }).to be_empty
|
|
end
|
|
|
|
it "can prune selectively" do
|
|
deps = described_class.expand(formula) do |_, dep|
|
|
next Dependable::PRUNE if dep.name == "foo"
|
|
end
|
|
|
|
expect(deps).to eq([bar, baz, qux])
|
|
end
|
|
|
|
it "preserves dependency order" do
|
|
allow(foo).to receive(:to_formula).and_return \
|
|
instance_double(Formula, name: "foo", full_name: "foo", deps: [qux, baz])
|
|
expect(described_class.expand(formula)).to eq([qux, baz, foo, bar])
|
|
end
|
|
end
|
|
|
|
it "skips optionals by default" do
|
|
deps = [build_dep(:foo, [:optional]), bar, baz, qux]
|
|
f = instance_double(Formula, deps:, build: instance_double(BuildOptions, with?: false), name: "f")
|
|
expect(described_class.expand(f)).to eq([bar, baz, qux])
|
|
end
|
|
|
|
it "keeps recommended dependencies by default" do
|
|
deps = [build_dep(:foo, [:recommended]), bar, baz, qux]
|
|
f = instance_double(Formula, deps:, build: instance_double(BuildOptions, with?: true), name: "f")
|
|
expect(described_class.expand(f)).to eq(deps)
|
|
end
|
|
|
|
it "merges repeated dependencies with differing options" do
|
|
foo2 = build_dep(:foo, ["option"])
|
|
baz2 = build_dep(:baz, ["option"])
|
|
deps << foo2 << baz2
|
|
deps = [foo2, bar, baz2, qux]
|
|
deps.zip(described_class.expand(formula)) do |expected, actual|
|
|
expect(expected.tags).to eq(T.must(actual).tags)
|
|
expect(expected).to eq(actual)
|
|
end
|
|
end
|
|
|
|
it "merges tags without duplicating them" do
|
|
foo2 = build_dep(:foo, ["option"])
|
|
foo3 = build_dep(:foo, ["option"])
|
|
deps << foo2 << foo3
|
|
|
|
expect(T.must(described_class.expand(formula).first).tags).to eq(%w[option])
|
|
end
|
|
|
|
it "skips parent but yields children with SKIP" do
|
|
f = instance_double(
|
|
Formula,
|
|
name: "f",
|
|
deps: [
|
|
build_dep(:foo, [], [bar, baz]),
|
|
build_dep(:foo, [], [baz]),
|
|
],
|
|
)
|
|
|
|
deps = described_class.expand(f) do |_dependent, dep|
|
|
next Dependable::SKIP if %w[foo qux].include? dep.name
|
|
end
|
|
|
|
expect(deps).to eq([bar, baz])
|
|
end
|
|
|
|
it "keeps dependency but prunes recursive dependencies with KEEP_BUT_PRUNE_RECURSIVE_DEPS" do
|
|
foo = build_dep(:foo, [:test], bar)
|
|
baz = build_dep(:baz, [:test])
|
|
f = instance_double(Formula, name: "f", deps: [foo, baz])
|
|
|
|
deps = described_class.expand(f) do |_dependent, dep|
|
|
next Dependable::KEEP_BUT_PRUNE_RECURSIVE_DEPS if dep.test?
|
|
end
|
|
|
|
expect(deps).to eq([foo, baz])
|
|
end
|
|
|
|
it "reuses formulae from the provided formula cache" do
|
|
shared_formula = instance_double(Formula, deps: [], name: "shared", full_name: "shared")
|
|
shared_dep = described_class.new("shared")
|
|
repeated_shared_dep = described_class.new("shared")
|
|
expect(shared_dep).to receive(:to_formula).once.and_return(shared_formula)
|
|
expect(repeated_shared_dep).not_to receive(:to_formula)
|
|
f = instance_double(
|
|
Formula,
|
|
name: "f",
|
|
full_name: "f",
|
|
deps: [
|
|
build_dep(:foo, [], [shared_dep]),
|
|
build_dep(:bar, [], [repeated_shared_dep]),
|
|
],
|
|
)
|
|
|
|
deps = described_class.expand(f, cache_key: "formula-cache-spec", formula_cache: {})
|
|
|
|
expect(deps.map(&:name)).to eq(%w[shared foo bar])
|
|
end
|
|
|
|
it "does not reuse formulae for uses_from_macos dependencies with different bounds" do
|
|
first_formula = instance_double(Formula, deps: [], name: "shared", full_name: "shared")
|
|
second_formula = instance_double(Formula, deps: [], name: "shared", full_name: "shared")
|
|
first_dep = UsesFromMacOSDependency.new("shared", [], bounds: { since: :ventura })
|
|
second_dep = UsesFromMacOSDependency.new("shared", [], bounds: { since: :sonoma })
|
|
expect(first_dep).to receive(:to_formula).once.and_return(first_formula)
|
|
expect(second_dep).to receive(:to_formula).once.and_return(second_formula)
|
|
f = instance_double(
|
|
Formula,
|
|
name: "f",
|
|
full_name: "f",
|
|
deps: [
|
|
build_dep(:foo, [], [first_dep]),
|
|
build_dep(:bar, [], [second_dep]),
|
|
],
|
|
)
|
|
|
|
deps = described_class.expand(f, cache_key: "uses-from-macos-formula-cache-spec", formula_cache: {})
|
|
|
|
expect(deps.map(&:name)).to eq(%w[shared foo bar])
|
|
end
|
|
|
|
it "returns only the dependencies given as a collection as second argument" do
|
|
expect(formula.deps).to eq([foo, bar, baz, qux])
|
|
expect(described_class.expand(formula, [bar, baz])).to eq([bar, baz])
|
|
end
|
|
|
|
it "doesn't raise an error when a dependency is cyclic" do
|
|
foo = build_dep(:foo)
|
|
bar = build_dep(:bar, [], [foo])
|
|
allow(foo).to receive(:to_formula).and_return \
|
|
instance_double(Formula, deps: [bar], name: foo.name, full_name: foo.name)
|
|
f = instance_double(Formula, name: "f", full_name: "f", deps: [foo, bar])
|
|
expect { described_class.expand(f) }.not_to raise_error
|
|
end
|
|
|
|
it "cleans the expand stack" do
|
|
foo = build_dep(:foo)
|
|
allow(foo).to receive(:to_formula).and_raise(FormulaUnavailableError, foo.name)
|
|
f = instance_double(Formula, name: "f", deps: [foo])
|
|
expect { described_class.expand(f) }.to raise_error(FormulaUnavailableError)
|
|
expect(described_class.expand_stack).to be_empty
|
|
end
|
|
end
|