Files
brew/Library/Homebrew/sandbox.rb
T
Mike McQuaid 377e4f740b Remove Bubblewrap, use Landlock for Linux sandbox
- Landlock needs no separate executable, installation or `sysctl`
  configuration, so use it as the only Linux sandbox implementation
  rather than an opt-in behind `$HOMEBREW_SANDBOX_LINUX_LANDLOCK`.
- Delete `Sandbox::Bubblewrap`, the `brew setup-sandbox` command and
  the implicit `bubblewrap` dependency, none of which Landlock needs.
- Remove the Bubblewrap-era `Sandbox` API (`ensure_sandbox_installed!`,
  `configure!`, `configuration_commands`, `sandbox_install_command`)
  and its call sites now that no backend needs installing or
  configuring.
- Simplify `brew doctor`'s `check_linux_sandbox` to report the
  Landlock failure reason with the `$HOMEBREW_NO_SANDBOX_LINUX`
  workaround.
2026-08-04 11:55:32 +01:00

634 lines
18 KiB
Ruby

# typed: strict
# frozen_string_literal: true
require "etc"
require "io/console"
require "pty"
require "tempfile"
require "exceptions"
require "utils/fork"
require "utils/output"
# Helper class for running a sub-process inside of a sandboxed environment.
class Sandbox
include Utils::Output::Mixin
extend Utils::Output::Mixin
# Privileged groups that are expected to be able to use a working sandbox.
PRIVILEGED_GROUPS = %w[admin staff root wheel].freeze
class SandboxPathFilter
sig { returns(String) }
attr_reader :path
sig { returns(Symbol) }
attr_reader :type
sig { params(path: String, type: Symbol).void }
def initialize(path:, type:)
@path = T.let(path.freeze, String)
@type = type
end
end
private_constant :SandboxPathFilter
class SandboxRule
sig { returns(T::Boolean) }
attr_reader :allow
sig { returns(String) }
attr_reader :operation
sig { returns(T.nilable(SandboxPathFilter)) }
attr_reader :filter
sig { returns(T.nilable(String)) }
attr_reader :modifier
sig {
params(allow: T::Boolean, operation: String, filter: T.nilable(SandboxPathFilter),
modifier: T.nilable(String)).void
}
def initialize(allow:, operation:, filter:, modifier:)
@allow = allow
@operation = operation
@filter = filter
@modifier = modifier
end
end
private_constant :SandboxRule
# Configuration profile for a sandbox.
class SandboxProfile
sig { returns(T::Array[SandboxRule]) }
attr_reader :rules
sig { void }
def initialize
@rules = T.let([], T::Array[SandboxRule])
end
sig { params(rule: SandboxRule).void }
def add_rule(rule)
@rules << rule
end
end
private_constant :SandboxProfile
sig { returns(T::Boolean) }
def self.available?
false
end
sig { returns(T::Boolean) }
def self.full_write_isolation? = true
# Whether Homebrew is itself running inside another sandbox, which would make
# its own nested sandbox hang (macOS) or fail to start (Linux). Overridden
# per-OS.
sig { returns(T::Boolean) }
def self.nested_sandbox? = false
# Skip Homebrew's own sandbox when it is opted into via
# `$HOMEBREW_AVOID_NESTED_SANDBOXING` and already running inside another
# sandbox. The skip is only supported for an unprivileged user in a custom
# prefix; error out explaining why rather than silently sandboxing (and
# hanging) when either is not the case.
sig { returns(T::Boolean) }
def self.avoid_nested_sandboxing?
return false unless Homebrew::EnvConfig.avoid_nested_sandboxing?
return false unless nested_sandbox?
if Homebrew.default_prefix?
odie "Refusing to skip the sandbox: `$HOMEBREW_AVOID_NESTED_SANDBOXING` is set " \
"inside another sandbox but Homebrew is using its default prefix " \
"(#{HOMEBREW_PREFIX}); this is only supported in a custom prefix."
end
privileged_group = PRIVILEGED_GROUPS.find do |name|
group = Etc.getgrnam(name)
group && Process.groups.include?(group.gid)
rescue ArgumentError
false
end
if privileged_group
odie "Refusing to skip the sandbox: `$HOMEBREW_AVOID_NESTED_SANDBOXING` is set " \
"inside another sandbox but you are in the privileged `#{privileged_group}` " \
"group; this is only supported for an unprivileged user."
end
true
end
sig { void }
def self.ensure_sandbox_available!
return if available?
raise failure_reason || "The sandbox is not available."
end
sig { returns(Symbol) }
def self.state
available? ? :available : :unavailable
end
sig { returns(T.nilable(String)) }
def self.failure_reason
return if state == :available
"The sandbox is not available."
end
sig { void }
def self.reset_state!; end
sig { params(command: T.any(String, Pathname), writable_path: T.any(String, Pathname), deny_network: T::Boolean).void }
def self.run_command(*command, writable_path:, deny_network: false)
ensure_sandbox_available!
writable_path = Pathname(writable_path).expand_path
if !writable_path.directory? || !writable_path.writable?
raise UsageError,
"`#{writable_path}` is not a writable directory."
end
writable_path = writable_path.realpath
sandbox = new
sandbox.allow_write_temp_and_cache
sandbox.allow_write_path writable_path
sandbox.deny_read_home
sandbox.deny_all_network if deny_network
sandbox.run "/bin/sh", "-c", "cd \"$1\" && shift && exec \"$@\"", "brew-sandbox-exec", writable_path, *command
end
sig { returns(String) }
def self.executable_name
raise NotImplementedError, "Sandbox is not implemented for this OS."
end
sig { returns(::PATH) }
def self.executable_candidate_paths
executable_path = Pathname.new(executable_name)
return PATH.new(executable_path.dirname) if executable_path.absolute?
PATH.new(ORIGINAL_PATHS, ENV.fetch("PATH"), HOMEBREW_ORIGINAL_BREW_FILE.dirname)
end
sig { returns(T.nilable(Pathname)) }
def self.executable
executable_candidate_paths.each do |path|
begin
candidate = Pathname.new(File.expand_path(executable_name, path))
rescue ArgumentError
next
end
next if !candidate.file? || !candidate.executable?
next unless executable_usable?(candidate)
return candidate
end
nil
end
sig { returns(Pathname) }
def self.executable!
executable || raise("#{executable_name} is required to use the sandbox.")
end
sig { params(_candidate: Pathname).returns(T::Boolean) }
def self.executable_usable?(_candidate)
true
end
sig { returns(Integer) }
def self.terminal_ioctl_request
raise NotImplementedError, "Sandbox is not implemented for this OS."
end
sig { void }
def initialize
@profile = T.let(SandboxProfile.new, SandboxProfile)
@failed = T.let(false, T::Boolean)
@logfile = T.let(nil, T.nilable(T.any(String, Pathname)))
@start = T.let(nil, T.nilable(Time))
end
sig { params(file: T.any(String, Pathname)).void }
def record_log(file)
@logfile = file
end
sig {
params(allow: T::Boolean, operation: String, filter: T.nilable(SandboxPathFilter),
modifier: T.nilable(String)).void
}
def add_rule(allow:, operation:, filter: nil, modifier: nil)
rule = SandboxRule.new(allow:, operation:, filter:, modifier:)
@profile.add_rule(rule)
end
sig { params(path: T.any(String, Pathname), type: Symbol).void }
def allow_read(path:, type: :literal)
add_rule allow: true, operation: "file-read*", filter: path_filter(path, type)
end
sig { params(path: T.any(String, Pathname), type: Symbol).void }
def deny_read(path:, type: :literal)
add_rule allow: false, operation: "file-read*", filter: path_filter(path, type)
end
sig { params(path: T.any(String, Pathname)).void }
def deny_read_path(path)
deny_read path:, type: :subpath
end
sig { void }
def deny_read_home
require "trust"
home = Pathname(Dir.home(ENV.fetch("USER"))).realpath
readable_paths = [
HOMEBREW_PREFIX,
HOMEBREW_REPOSITORY,
HOMEBREW_CACHE,
HOMEBREW_LOGS,
HOMEBREW_TEMP,
ENV.fetch("GITHUB_WORKSPACE", nil),
ENV.fetch("RUNNER_WORKSPACE", nil),
ENV.fetch("RUNNER_TEMP", nil),
Homebrew::Trust.trust_file,
*home_write_paths.select { |path| File.exist?(path) },
].compact.flat_map do |path|
path = Pathname(path)
[path.expand_path, (path.realpath if path.exist?)].compact
end
if readable_paths.any? { |path| path.ascend.include?(home) }
# When Homebrew or CI needs some `$HOME` paths to stay readable, deny only
# well-known credential and personal-data paths instead of enumerating all
# of `$HOME`.
[
".ssh",
".aws",
".azure",
".boto",
".docker",
".config/fish",
".config/gh",
".config/gcloud",
".config/huggingface",
".config/pip",
".config/pypoetry",
".config/rclone",
".config/containers/auth.json",
".config/composer/auth.json",
".config/sops/age/keys.txt",
".gnupg",
".git-credentials",
".gitconfig",
".gsutil",
".kube",
".netrc",
".npmrc",
".yarnrc",
".yarnrc.yml",
".pnpmrc",
".bunfig.toml",
".pypirc",
".pip",
".poetry",
".local/share/pypoetry",
".gem/credentials",
".bundle/config",
".cargo/credentials",
".cargo/credentials.toml",
".composer/auth.json",
".condarc",
".m2/settings.xml",
".gradle/gradle.properties",
".sbt/1.0/credentials.sbt",
".terraform.d/credentials.tfrc.json",
".pulumi/credentials.json",
".oci/config",
".huggingface/token",
".cache/huggingface/token",
".claude",
".claude.json",
".kiro",
".bash_login",
".bash_logout",
".bash_profile",
".bashrc",
".bash_history",
".profile",
".zlogin",
".zlogout",
".zprofile",
".zshenv",
".zshrc",
".zsh_history",
".python_history",
".mysql_history",
".psql_history",
".env",
".env.local",
"Documents",
"Movies",
"Music",
"Pictures",
"Library/Keychains",
"Library/Mobile Documents",
"Library/CloudStorage",
"Dropbox",
"Google Drive",
"OneDrive",
].each do |path|
path = home/path
next unless path.exist?
path = path.realpath
next unless path.ascend.include?(home)
if (readable_path = readable_paths.find { |required_path| required_path.ascend.include?(path) })
opoo <<~EOS
The sandbox cannot prevent formulae from reading:
#{path}
because this required path is inside it:
#{readable_path}
Formulae may access personal data in this directory.
EOS
next
end
deny_read_path path
rescue Errno::ENOENT
nil
end
return
end
deny_read_path home
end
sig { params(path: T.nilable(T.any(String, Pathname)), type: Symbol).void }
def allow_read_if_exists(path:, type: :literal)
return unless path
return unless File.exist?(path)
allow_read path:, type:
end
sig { params(path: T.any(String, Pathname), type: Symbol).void }
def allow_write(path:, type: :literal)
add_rule allow: true, operation: "file-write*", filter: path_filter(path, type)
add_rule allow: true, operation: "file-write-setugid", filter: path_filter(path, type)
add_rule allow: true, operation: "file-write-mode", filter: path_filter(path, type)
end
sig { params(path: T.any(String, Pathname), type: Symbol).void }
def deny_write(path:, type: :literal)
add_rule allow: false, operation: "file-write*", filter: path_filter(path, type)
end
sig { params(path: T.any(String, Pathname)).void }
def allow_write_path(path)
allow_write path:, type: :subpath
end
sig { params(path: T.nilable(T.any(String, Pathname))).void }
def allow_write_path_if_exists(path)
return unless path
return unless File.exist?(path)
allow_write_path path
end
sig { params(path: T.any(String, Pathname)).void }
def deny_write_path(path)
deny_write path:, type: :subpath
end
sig { void }
def allow_write_temp_and_cache
allow_write_path HOMEBREW_TEMP
allow_write_path HOMEBREW_CACHE
end
sig { void }
def allow_cvs
allow_write_path "#{Dir.home(ENV.fetch("USER"))}/.cvspass"
end
sig { void }
def allow_fossil
allow_write_path "#{Dir.home(ENV.fetch("USER"))}/.fossil"
allow_write_path "#{Dir.home(ENV.fetch("USER"))}/.fossil-journal"
end
sig { params(formula: Formula).void }
def allow_write_cellar(formula)
allow_write_path formula.rack
allow_write_path formula.etc
allow_write_path formula.var
end
sig { void }
def allow_write_xcode; end
sig { params(formula: Formula).void }
def allow_write_log(formula)
allow_write_path formula.logs
end
sig { void }
def deny_write_homebrew_repository
deny_write path: HOMEBREW_ORIGINAL_BREW_FILE
if HOMEBREW_PREFIX.to_s == HOMEBREW_REPOSITORY.to_s
deny_write_path HOMEBREW_LIBRARY
deny_write_path HOMEBREW_REPOSITORY/".git"
else
deny_write_path HOMEBREW_REPOSITORY
end
end
sig { params(path: T.any(String, Pathname), type: Symbol).void }
def allow_network(path:, type: :literal)
add_rule allow: true, operation: "network*", filter: path_filter(path, type)
end
sig { void }
def deny_all_network
add_rule allow: false, operation: "network*"
end
sig { params(args: T.any(String, Pathname)).void }
def run(*args)
Dir.mktmpdir("homebrew-sandbox", HOMEBREW_TEMP) do |tmpdir|
allow_network path: File.join(tmpdir, "socket"), type: :literal if allow_network_for_error_pipe?
@start = T.let(Time.now, T.nilable(Time))
begin
command = sandbox_command(args, tmpdir)
# Start sandbox in a pseudoterminal to prevent access of the parent terminal.
PTY.open do |controller, worker|
# Set the PTY's window size to match the parent terminal.
# Some formula tests are sensitive to the terminal size and fail if this is not set.
winch = proc do |_sig|
controller.winsize = if $stdout.tty?
# We can only use IO#winsize if the IO object is a TTY.
$stdout.winsize
else
# Otherwise, default to tput, if available.
# This relies on ncurses rather than the system's ioctl.
[Utils.popen_read("tput", "lines").to_i, Utils.popen_read("tput", "cols").to_i]
end
end
write_to_pty = proc do
# Don't hang if stdin is not able to be used - throw EIO instead.
old_ttin = trap(:TTIN, "IGNORE")
# Update the window size whenever the parent terminal's window size changes.
old_winch = trap(:WINCH, &winch)
winch.call(nil)
stdin_thread = Thread.new do
IO.copy_stream($stdin, controller)
rescue Errno::EIO
# stdin is unavailable - move on.
end
stdout_thread = Thread.new do
copy_pty_output(controller)
end
Utils.safe_fork(directory: tmpdir, yield_parent: true) do |error_pipe|
if error_pipe
# Child side
Process.setsid
controller.close
worker.ioctl(self.class.terminal_ioctl_request, 0) # Make this the controlling terminal.
ensure_child_tty_available
# Move into a non-denied directory before `exec` so subsequent
# `getcwd(3)` calls (which walk every parent) never cross a
# `deny_read_home` path inherited from the caller's CWD.
Dir.chdir(tmpdir)
worker.close_on_exec = true
apply_sandbox
exec(*command, in: worker, out: worker, err: worker) # And map everything to the PTY.
else
# Parent side
worker.close
end
end
rescue ChildProcessError => e
raise ErrorDuringExecution.new(command, status: e.status)
ensure
stdin_thread&.kill
stdout_thread&.kill
trap(:TTIN, old_ttin)
trap(:WINCH, old_winch)
end
if $stdin.tty?
# If stdin is a TTY, use io.raw to set stdin to a raw, passthrough
# mode while we copy the input/output of the process spawned in the
# PTY. After we've finished copying to/from the PTY process, io.raw
# will restore the stdin TTY to its original state.
begin
# Ignore SIGTTOU as setting raw mode will hang if the process is in the background.
old_ttou = trap(:TTOU, "IGNORE")
$stdin.raw(&write_to_pty)
ensure
trap(:TTOU, old_ttou)
end
else
write_to_pty.call
end
end
rescue
@failed = true
raise
ensure
record_sandbox_log
end
end
end
# @api private
sig { params(path: T.any(String, Pathname), type: Symbol).returns(SandboxPathFilter) }
def path_filter(path, type)
# Any character is allowed: the OS-specific renderer quotes paths safely
# (the seatbelt renderer escapes the `"` and `\` string delimiters; the
# Linux sandbox passes each path as a separate argument), so even paths
# with spaces, parentheses, quotes, backslashes or newlines are expressible.
filter_path = case type
when :regex then path.to_s
when :subpath, :literal
expand_realpath(Pathname.new(path)).to_s
else raise ArgumentError, "Invalid path filter type: #{type}"
end
SandboxPathFilter.new(path: filter_path, type:)
end
sig { returns(SandboxProfile) }
attr_reader :profile
sig { params(controller: IO).void }
def copy_pty_output(controller)
controller.each_char { |c| print(c) }
rescue Errno::EIO
# Linux marks a PTY as an I/O error when its peer closes, so treat this as EOF:
# https://github.com/torvalds/linux/blob/master/drivers/tty/pty.c
end
private
sig { returns(T::Boolean) }
attr_reader :failed
sig { returns(T.nilable(T.any(String, Pathname))) }
attr_reader :logfile
sig { returns(T.nilable(Time)) }
attr_reader :start
# Home directories a build needs to write to, and so must also read;
# overridden per-OS (e.g. the Xcode directories on macOS).
sig { returns(T::Array[String]) }
def home_write_paths = []
sig { params(_args: T::Array[T.any(String, Pathname)], _tmpdir: String).returns(T::Array[T.any(String, Pathname)]) }
def sandbox_command(_args, _tmpdir)
raise NotImplementedError, "Sandbox is not implemented for this OS."
end
sig { returns(T::Boolean) }
def allow_network_for_error_pipe?
false
end
sig { void }
def ensure_child_tty_available; end
sig { void }
def apply_sandbox; end
sig { void }
def record_sandbox_log; end
sig { params(path: Pathname).returns(Pathname) }
def expand_realpath(path)
raise unless path.absolute?
path.exist? ? path.realpath : expand_realpath(path.parent)/path.basename
end
end
require "extend/os/sandbox"