mirror of
https://github.com/Homebrew/brew.git
synced 2026-08-12 22:29:27 +04:00
- A plain `brew upgrade` raised "It seems there is already a Binary at ..." even when the existing symlink resolved to the exact source about to be linked, because the realpath check sat behind `force`/`adopt`. The revert left the symlink in place so every retry failed identically until manual intervention. - Treat an already-correct symlink as a no-op: log and skip the link. Genuine conflicts, such as a real file at the target or a symlink elsewhere, still require `--force` or `--adopt`. - Rescue errors resolving the target, like `conflicting_formula` does, so unreadable symlinks fall back to the existing conflict and error handling instead of raising `Errno` exceptions. - Fixes Homebrew/brew#23426.
146 lines
4.5 KiB
Ruby
146 lines
4.5 KiB
Ruby
# typed: strict
|
|
# frozen_string_literal: true
|
|
|
|
require "cask/artifact/relocated"
|
|
|
|
module Cask
|
|
module Artifact
|
|
# Superclass for all artifacts which are installed by symlinking them to the target location.
|
|
class Symlinked < Relocated
|
|
sig { returns(String) }
|
|
def self.link_type_english_name
|
|
"Symlink"
|
|
end
|
|
|
|
sig { returns(String) }
|
|
def self.english_description
|
|
"#{english_name} #{link_type_english_name}s"
|
|
end
|
|
|
|
sig {
|
|
params(
|
|
force: T::Boolean,
|
|
adopt: T::Boolean,
|
|
command: T.class_of(SystemCommand),
|
|
options: T.anything,
|
|
).void
|
|
}
|
|
def install_phase(force: false, adopt: false, command: SystemCommand, **options)
|
|
link(force:, adopt:, command:, **options)
|
|
end
|
|
|
|
sig {
|
|
params(
|
|
command: T.class_of(SystemCommand),
|
|
_options: T.anything,
|
|
).void
|
|
}
|
|
def uninstall_phase(command: SystemCommand, **_options)
|
|
unlink(command:)
|
|
end
|
|
|
|
sig { returns(String) }
|
|
def summarize_installed
|
|
if target.symlink? && target.exist? && target.readlink.exist?
|
|
"#{printable_target} -> #{target.readlink} (#{target.readlink.abv})"
|
|
else
|
|
string = if target.symlink?
|
|
"#{printable_target} -> #{target.readlink}"
|
|
else
|
|
printable_target
|
|
end
|
|
|
|
Formatter.error(string, label: "Broken Link")
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
sig {
|
|
overridable.params(
|
|
force: T::Boolean,
|
|
adopt: T::Boolean,
|
|
command: T.class_of(SystemCommand),
|
|
_options: T.anything,
|
|
).void
|
|
}
|
|
def link(force: false, adopt: false, command: SystemCommand, **_options)
|
|
unless source.exist?
|
|
raise CaskError,
|
|
"It seems the #{self.class.link_type_english_name.downcase} " \
|
|
"source '#{source}' is not there."
|
|
end
|
|
|
|
if target.exist?
|
|
message = "It seems there is already #{self.class.english_article} " \
|
|
"#{self.class.english_name} at '#{target}'"
|
|
|
|
if (force || adopt) && target.symlink? &&
|
|
(target.realpath == source.realpath || target.realpath.to_s.start_with?("#{cask.caskroom_path}/"))
|
|
opoo "#{message}; overwriting."
|
|
Utils.gain_permissions_remove(target, command:)
|
|
elsif target_links_to_source?
|
|
ohai "#{self.class.english_name} '#{source.basename}' is already linked to '#{target}'"
|
|
return
|
|
elsif (formula = conflicting_formula)
|
|
opoo "#{message} from formula #{formula}; skipping link."
|
|
return
|
|
else
|
|
raise CaskError, "#{message}."
|
|
end
|
|
end
|
|
|
|
ohai "Linking #{self.class.english_name} '#{source.basename}' to '#{target}'"
|
|
create_filesystem_link(command)
|
|
end
|
|
|
|
sig { params(command: T.class_of(SystemCommand)).void }
|
|
def unlink(command: SystemCommand)
|
|
return unless target.symlink?
|
|
|
|
ohai "Unlinking #{self.class.english_name} '#{target}'"
|
|
|
|
if (formula = conflicting_formula)
|
|
odebug "#{target} is from formula #{formula}; skipping unlink."
|
|
return
|
|
end
|
|
|
|
Utils.gain_permissions_remove(target, command:)
|
|
end
|
|
|
|
sig { params(command: T.class_of(SystemCommand)).void }
|
|
def create_filesystem_link(command)
|
|
Utils.gain_permissions_mkpath(target.dirname, command:)
|
|
|
|
command.run! "/bin/ln", args: ["--no-dereference", "--force", "--symbolic", source, target],
|
|
sudo: !target.dirname.writable?
|
|
end
|
|
|
|
sig { returns(T::Boolean) }
|
|
def target_links_to_source?
|
|
target.symlink? && target.realpath == source.realpath
|
|
rescue => e
|
|
odebug "Error checking whether #{target} links to #{source}: #{e}"
|
|
false
|
|
end
|
|
|
|
# Check if the target file is a symlink that originates from a formula
|
|
# with the same name as this cask, indicating a potential conflict
|
|
sig { returns(T.nilable(String)) }
|
|
def conflicting_formula
|
|
if target.symlink? && target.exist? &&
|
|
(match = target.realpath.to_s.match(%r{^#{HOMEBREW_CELLAR}/(?<formula>[^/]+)/}o))
|
|
match[:formula]
|
|
end
|
|
rescue => e
|
|
# If we can't determine the realpath or any other error occurs,
|
|
# don't treat it as a conflicting formula file
|
|
odebug "Error checking for conflicting formula file: #{e}"
|
|
nil
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
require "extend/os/cask/artifact/symlinked"
|