mirror of
https://github.com/ggml-org/whisper.cpp.git
synced 2026-08-12 22:31:22 +04:00
whisper : heap out-of-bounds read in log_mel_spectrogram on very short audio (#3956)
log_mel_spectrogram reflect-pads the start of the audio buffer by reading 200 samples from samples[1], with no check that the input has that many samples. Audio shorter than 201 samples reads past the end of `samples` (heap out-of-bounds read); the existing minimum-length check runs later, in whisper_full_with_state, after this access. Clamp the reflected count to the available input. Normal-length audio (n_samples >= 201) is unchanged.
This commit is contained in:
+6
-2
@@ -3203,8 +3203,12 @@ static bool log_mel_spectrogram(
|
|||||||
// pad 30 seconds of zeros at the end of audio (480,000 samples) + reflective pad 200 samples at the end of audio
|
// pad 30 seconds of zeros at the end of audio (480,000 samples) + reflective pad 200 samples at the end of audio
|
||||||
std::fill(samples_padded.begin() + n_samples + stage_2_pad, samples_padded.begin() + n_samples + stage_1_pad + 2 * stage_2_pad, 0);
|
std::fill(samples_padded.begin() + n_samples + stage_2_pad, samples_padded.begin() + n_samples + stage_1_pad + 2 * stage_2_pad, 0);
|
||||||
|
|
||||||
// reflective pad 200 samples at the beginning of audio
|
// reflective pad up to 200 samples at the beginning of audio
|
||||||
std::reverse_copy(samples + 1, samples + 1 + stage_2_pad, samples_padded.begin());
|
// clamp the reflected count to the available input so very short audio (n_samples <= stage_2_pad)
|
||||||
|
// does not read past the end of `samples`
|
||||||
|
const int64_t n_reflect = std::min<int64_t>(stage_2_pad, std::max<int64_t>(0, (int64_t) n_samples - 1));
|
||||||
|
std::reverse_copy(samples + 1, samples + 1 + n_reflect, samples_padded.begin() + (stage_2_pad - n_reflect));
|
||||||
|
|
||||||
|
|
||||||
mel.n_mel = n_mel;
|
mel.n_mel = n_mel;
|
||||||
// https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/SpectralOps.cpp#L936
|
// https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/SpectralOps.cpp#L936
|
||||||
|
|||||||
Reference in New Issue
Block a user