100 Commits
Author SHA1 Message Date
Jack Nagel 690bf9b8b9 Remove myself from the maintainers list
It's been fun.
2015-07-04 23:04:02 -04:00
Jack Nagel 7690a00d04 Stdlib check should use the compiler used to build the bottle 2015-06-27 20:04:45 -04:00
Jack Nagel 0f745872df Updated outdated comment 2015-06-27 20:04:45 -04:00
Jack Nagel 929fd12650 Remove unused method 2015-06-27 16:25:44 -04:00
Jack Nagel 27e184f543 Mark some requirements that don't need the build environment 2015-06-26 00:00:44 -04:00
Jack Nagel e40b735217 Decouple detect_stdlibs from ENV
I want to decouple from the global ENV constant as much as possible so
that eventually we can change the build environment implementation.
detect_stdlibs only cares about the compiler, not the whole ENV.
2015-06-25 23:42:54 -04:00
Jack Nagel 2bc40ff385 Pull complex condition out of loop 2015-06-25 19:33:47 -04:00
Jack Nagel 75642e6271 Use Dir.mktmpdir in doctor
This matches how we create temporary directories elsewhere.
2015-06-23 23:20:31 -04:00
Jack Nagel a1c1c1e3d3 Whitelist ntfs-3g libs
Closes Homebrew/homebrew#40950.
2015-06-23 23:20:31 -04:00
Jack Nagel 22269b7007 Fix audit when tap is nil
This is the case when a formula is passed as a filename.
2015-06-23 19:58:37 -04:00
Jack Nagel 5e7edbbd3c Ask the exception for the formula name 2015-06-22 21:08:27 -04:00
Jack Nagel 87e7735012 Ask the formula object for the opt path 2015-06-22 21:00:40 -04:00
Jack Nagel f1bf81dd55 Simplify gcc_version_formula 2015-06-21 21:18:24 -04:00
Jack Nagel 1ce04786d6 Inline variable 2015-06-21 21:18:24 -04:00
Jack Nagel 3f11f1a0de Eliminate special case for core gcc 2015-06-21 21:18:24 -04:00
Jack Nagel 2db59be452 Less code in begin/rescue block 2015-06-21 21:18:23 -04:00
Jack Nagel 1bba5fd88a Pass full match to warn_about_non_apple_gcc 2015-06-21 21:18:23 -04:00
Jack Nagel 7c83e3ffe3 Remove workarounds for destructuring single-element hashes 2015-06-19 22:30:13 -04:00
Jack Nagel ec1727a1be Remove backports for Ruby 1.8.6
refs. Homebrew/linuxbrew#438, mistydemeo/tigerbrew#327,
mistydemeo/tigerbrew#334
2015-06-19 22:20:47 -04:00
Jack Nagel 09f8c54f83 Move some constants from env to compiler constants 2015-06-19 21:38:39 -04:00
Jack Nagel 7edf3c88f6 Pass formula objects, not strings, into the build environment 2015-06-18 23:13:48 -04:00
Jack Nagel 44feb5b8f9 Add opt_frameworks helper 2015-06-17 21:31:27 -04:00
Jack Nagel 38974ed6b5 Run tests for both build environments 2015-06-17 20:04:21 -04:00
Jack Nagel 72cb403a56 Move 10.11 warning to doctor, pre-install, and post-failure
Fixes Homebrew/homebrew#40778.
2015-06-16 20:02:10 -04:00
Jack Nagel f59b164733 Add explicit branch for 10.11 in Xcode version list 2015-06-16 20:02:10 -04:00
Jack Nagel f4027cc9ac "Mac OS X" -> "OS X" in copy 2015-06-16 20:02:10 -04:00
Jack Nagel f13ac9b0c8 Decouple the local bottle strategy from the formula 2015-06-15 21:32:15 -04:00
Jack Nagel 321476df08 Make CurlUnsafeDownloadStrategy a no-op 2015-06-15 21:32:15 -04:00
Jack Nagel 023bddbd04 Make UnsafeSubversionDownloadStrategy a no-op 2015-06-15 21:32:15 -04:00
Jack Nagel 8bdc7b92d8 Call expand_path on the value of HOMEBREW_CACHE
Fixes Homebrew/homebrew#40752.
2015-06-15 21:21:53 -04:00
Jack Nagel 7b733b4087 Add pkgconfig files for 10.11
Fixes Homebrew/homebrew#40656.
2015-06-15 20:43:24 -04:00
Jack Nagel 621a7ada95 Remove reference to "open" command
Closes Homebrew/homebrew#40706.
2015-06-15 20:08:46 -04:00
Jack Nagel 357648a8c4 Only look for libraries in lib if it exists
Fixes Homebrew/homebrew#40630.
2015-06-14 22:07:59 -04:00
Jack Nagel 552755b3de Update minitest 2015-06-13 21:11:32 -04:00
Jack Nagel be9c5d5d16 Remove some 10.5 hacks 2015-06-13 17:18:17 -04:00
Jack Nagel bd0f179478 Remove obsolete doctor check
We don't support 10.5 anymore, and tigerbrew doesn't have this check
anymore, either.
2015-06-12 22:58:04 -04:00
Jack Nagel c4dfacaf0c Fix linked keg-only check when only directories are linked 2015-06-12 20:37:20 -04:00
Jack Nagel aad4ed7faa Undocument return value of ENV.deparallelize
It's not clear whether it returns MAKEFLAGS with or without -j<n>, and
neither is particularly useful behavior, given you can easily get the
exact value by calling ENV["MAKEFLAGS"]. So let's not commit to this
API.
2015-06-12 20:14:07 -04:00
Jack Nagel d3ab5e6034 Revert "audit: add rules for non-ascii character and encoding comment"
This reverts commit ab8fe812377bc60cc18fe8d7c1ea8ce2f0269294.
2015-06-08 22:27:28 -04:00
Jack Nagel 7d8bec3f20 Always treat formula files as UTF-8 2015-06-08 22:27:27 -04:00
Jack Nagel 9516444dfd Give namespace modules a name so formula objects can be marshaled
Fixes Homebrew/homebrew#40311.
2015-06-02 20:51:16 -04:00
Jack Nagel 45a71898e8 Isolate formula class namespaces
Closes Homebrew/homebrew#40151.
Closes Homebrew/homebrew#40203.
2015-06-01 19:24:47 -04:00
Jack Nagel 0fc906b03d Remove another unused default argument 2015-05-29 00:23:06 -04:00
Jack Nagel f80748096d Remove unused default argument 2015-05-29 00:16:51 -04:00
Jack Nagel 5cb392d9d7 Revert "Check empty? to avoid introducing nils"
This reverts commit 580cd173cbf92aa9851e68d635af518a668a6cdc.
2015-05-28 23:57:02 -04:00
Jack Nagel aac0e4a878 Fix variable reference 2015-05-27 23:32:06 -04:00
Jack Nagel efd52da101 Remove dead code 2015-05-27 21:57:41 -04:00
Jack Nagel be0a1e7635 Check empty? to avoid introducing nils
[].last => nil
[].max => nil
2015-05-26 19:51:30 -04:00
Jack Nagel e398e4519d Add test demonstrating installing a relative symlink 2015-05-21 20:43:38 -04:00
Jack Nagel 703d8a1aa3 Revert "Remove conditional"
This method may see values originating HOMEBREW_CC.

This reverts commit 9c74f42962090c016143744b057e13aa75d9b13e.
2015-05-17 19:22:08 -04:00
Jack Nagel bf4dc7449b Clear GOPATH and GOROOT in build environment
Fixes Homebrew/homebrew#37936.
2015-05-14 20:04:45 -04:00
Jack Nagel f242381e2a Tweak audit copy
URLs are not links.
2015-05-14 00:15:41 -04:00
Jack Nagel b638c1d597 Use "directory", not "folder" 2015-05-14 00:15:41 -04:00
Jack Nagel c16a1d9aba Extend gnome stable/unstable audit to download.gnome.org URLs 2015-05-14 00:01:00 -04:00
Jack Nagel ff11789933 Close the socket after sending the file descriptor to the child
Fixes Homebrew/homebrew#39691.
2015-05-12 21:53:04 -04:00
Jack Nagel eda5922eb4 Disable trailing comma style rule for Ruby 1.8 support 2015-05-12 21:06:48 -04:00
Jack Nagel e04e898d5c Avoid explicit control flow 2015-05-12 20:33:34 -04:00
Jack Nagel 71f4e90cdb Handle deprecated options in dependency specifications
Fixes Homebrew/homebrew#38069.
2015-05-11 22:07:14 -04:00
Jack Nagel 37b5fb2e1e Stop enforcing the use of "fail" instead of "raise"
We use raise everywhere else in the codebase.
2015-05-10 20:40:10 -04:00
Jack Nagel dcaaa20b34 Remove conditional 2015-05-08 22:23:30 -04:00
Jack Nagel 3895a0ae23 Rename method 2015-05-07 23:18:01 -04:00
Jack Nagel 41ecce7898 Push URL audits down to ResourceAuditor 2015-05-07 22:44:45 -04:00
Jack Nagel 5c8ceaa458 Warn about duplicated URLs
Closes Homebrew/homebrew#39486.
2015-05-07 22:15:57 -04:00
Jack Nagel 43ce8b0791 Stop testing implementation 2015-05-04 20:43:08 -04:00
Jack Nagel 04ac482809 Revert "Default HOMEBREW_TEMP to Dir.tmpdir"
This reverts commit b95f27ce9f956c56d080b6dc29ba8efb841c6690.
2015-05-03 10:46:23 -04:00
Jack Nagel fe588311cc Use predicate method 2015-05-01 00:00:55 -04:00
Jack Nagel a14085acd3 Default HOMEBREW_TEMP to Dir.tmpdir 2015-04-30 20:11:18 -04:00
Jack Nagel c7ca28a161 Fix encoding of output string 2015-04-30 19:42:54 -04:00
Jack Nagel e023d869a2 Revert "test-bot: try to handle bad UTF-8 output."
This reverts commit b4c2b8f3b4b58ef10ab8f748c743a3352f4cee7d.
2015-04-30 19:41:58 -04:00
Jack Nagel c10f19c838 Installation tests now use the actual installer 2015-04-29 19:15:11 -04:00
Jack Nagel 2ca8172fe9 Let the test environment inject its own load path 2015-04-29 19:15:11 -04:00
Jack Nagel 80403db9a1 Use Dir.tmpdir rather than /tmp in test environment 2015-04-29 19:15:11 -04:00
Jack Nagel dc6af1a6ae Ensure HOMEBREW_TEMP is respected in all tests 2015-04-29 19:15:11 -04:00
Jack Nagel 44ca2043d0 Allow test tmpdir to be passed in 2015-04-29 19:15:11 -04:00
Jack Nagel 0397d68259 Extract runtime configuration from global.rb
This allows global.rb to be safely loaded in the test environment.
2015-04-29 19:15:11 -04:00
Jack Nagel ba26567b03 Manage sandbox test resources in setup/teardown 2015-04-28 22:36:54 -04:00
Jack Nagel c07da9485f The forked build process should never run at_exit handlers
We don't use at_exit anywhere that matters, but the test framework does.
2015-04-28 01:39:28 -04:00
Jack Nagel bae31c0b9e Fix passed-in formula name to match the class name 2015-04-28 01:39:28 -04:00
Jack Nagel 92cbac7966 Simplify substitution 2015-04-27 20:39:20 -04:00
Jack Nagel cac6f2f070 Fix variable name 2015-04-26 21:59:47 -04:00
Jack Nagel b42259f628 Fix variable name 2015-04-26 21:56:22 -04:00
Jack Nagel 913c12fd43 Keep subprocess code inside begin block 2015-04-25 23:22:58 -04:00
Jack Nagel f7ded45bc7 Clean up socket and filesystem resources separately 2015-04-25 23:17:13 -04:00
Jack Nagel 16dfe3dd40 Add Formula#logs 2015-04-25 23:14:05 -04:00
Jack Nagel 39b890e255 Remove test that may alter the repository 2015-04-21 20:46:02 -04:00
Jack Nagel d4c8f83381 Inline error message 2015-04-21 20:46:02 -04:00
Jack Nagel f0eca11d6b Revert "Use real repo to run tests"
This reverts commit 5aaf13c6cf784cb4be62932b3e528e8f93580a65.
2015-04-20 22:33:25 -04:00
Jack Nagel 6278e08aec Use real repo to run tests 2015-04-20 21:00:26 -04:00
Jack Nagel f9900a5dbf Remove assertion that is coupled to test prefix structure 2015-04-20 20:58:33 -04:00
Jack Nagel 2fb9890e07 Don't use deprecated API 2015-04-20 20:49:55 -04:00
Jack Nagel 136bc02374 Simplify setting load path 2015-04-20 20:31:16 -04:00
Jack Nagel 11c513efbd Our internal directory structure is private 2015-04-20 20:25:13 -04:00
Jack Nagel d6bca69347 Revert "audit: enforce new https url style for gnome downloads"
I would like there to be more discussion before making this change.

This reverts commit f16ffd2a9ee5d29c7c0ae672c17bd129240adbb5.
2015-04-19 12:48:09 -04:00
Jack Nagel 47aae82d33 Remove bad test 2015-04-18 15:20:58 -04:00
Jack Nagel a5c9c586ff Move can_cleanup? off of the formula instance 2015-04-17 22:58:02 -04:00
Jack Nagel 338a08d8d6 Ask the formula if it can be cleaned up once 2015-04-17 22:58:02 -04:00
Jack Nagel 505d06c176 Simplify cleanup eligibility check 2015-04-17 22:58:02 -04:00
Jack Nagel c2dcd91bd1 Eliminate a place where ARGV is mutated 2015-04-16 22:20:59 -04:00
Jack Nagel cc92f491c8 Fix test formula name so it matches the filename 2015-04-15 21:28:23 -04:00
Jack Nagel 0d6545363d Update test dependencies 2015-04-13 20:04:39 -04:00