lychee.tests.network: use with subtest

pkgs/by-name/ly/lychee/tests/network.nix

@@ -55,31 +55,29 @@ in
         curl --fail -v http://example
     """)
 
-    # FAILURE CASE
+    # TEST CASES
 
-    client.succeed("""
-        exec 1>&2
-        r=0
-        ${lib.getExe check.online} || {
-          r=$?
-        }
-        if [[ $r -ne 2 ]]; then
-            echo "lycheeLinkCheck unexpected exit code $r"
-            exit 1
-        fi
-    """)
+    with subtest("online check detects broken links"):
+        client.succeed("""
+            exec 1>&2
+            r=0
+            ${lib.getExe check.online} || {
+              r=$?
+            }
+            if [[ $r -ne 2 ]]; then
+                echo "lycheeLinkCheck unexpected exit code $r"
+                exit 1
+            fi
+        """)
 
-    # SUCCESS CASE
+    with subtest("online check succeeds when links are fixed"):
+        example.succeed("""
+            echo '<h1>foo</h1>' > /var/www/example/foo.html
+        """)
 
-    example.succeed("""
-        echo '<h1>foo</h1>' > /var/www/example/foo.html
-    """)
-
-    client.succeed("""
-        ${lib.getExe check.online}
-    """)
-
-    # EXTRA ARGS CASE: verify extraArgs are passed through to online wrapper
+        client.succeed("""
+            ${lib.getExe check.online}
+        """)
 
     with subtest("extraArgs are passed to the online wrapper"):
         client.succeed("""